doc: add pronouns for ofrobots #19992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
added
the
fast-track
BethGriggs
approved these changes
Apr 12, 2018
hiroppy
approved these changes
Apr 12, 2018
devsnek
approved these changes
Apr 12, 2018
README.md
Outdated
| @@ -443,7 +443,7 @@ For more information about the governance of the Node.js project, see | |||
| * [not-an-aardvark](https://github.com/not-an-aardvark) - | |||
| **Teddy Katz** <teddy.katz@gmail.com> | |||
| * [ofrobots](https://github.com/ofrobots) - | |||
| **Ali Ijaz Sheikh** <ofrobots@google.com> | |||
| **Ali Ijaz Sheikh** <ofrobots@google.com> (he/him); | |||
There was a problem hiding this comment.
Beware semicolon:
> (he/him); ->> (he/him)
vsemozhetbyt
approved these changes
Apr 12, 2018
cjihrig
approved these changes
Apr 13, 2018
|
landed in 2a6ab9b |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 13, 2018
PR-URL: #19992 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Not a big deal in this case, but it looks like this didn't get a lite CI. Doc changes should get the lite CI so that markdown linting happens. |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #19992 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#19992 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I added them
But they weren't there
No idea how this happened
Herein I declare
Checklist