doc: fix errors in sample code comments #19963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors thrown have changed in a few places. Update the comments to reflect the current errors. The `noAssert` option has been removed but it is still shown in sample code in a few places. Remove that sample code.
nodejs-github-bot
added
buffer
|
@nodejs/documentation @nodejs/buffer |
|
Lite CI again: https://ci.nodejs.org/job/node-test-pull-request-lite/499/ (Anyone know why lite CI aborts sometimes as in the previous run in the comment above? @nodejs/build) |
trivikr
approved these changes
Apr 12, 2018
danbev
approved these changes
Apr 12, 2018
vsemozhetbyt
added
fast-track
vsemozhetbyt
approved these changes
Apr 12, 2018
BridgeAR
approved these changes
Apr 12, 2018
cjihrig
approved these changes
Apr 12, 2018
benjamingr
approved these changes
Apr 12, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 12, 2018
The errors thrown have changed in a few places. Update the comments to reflect the current errors. The `noAssert` option has been removed but it is still shown in sample code in a few places. Remove that sample code. PR-URL: nodejs#19963 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in 3bd6d8d 🎉 |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
The errors thrown have changed in a few places. Update the comments to reflect the current errors. The `noAssert` option has been removed but it is still shown in sample code in a few places. Remove that sample code. PR-URL: #19963 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
This needs a manual backport because the examples diverge from the state in v.9.x. The error messages were changed in a semver-major commit. |
|
With 9.x in maintenance mode and about to go EOL in the next month, I'm inclined to not backport this relatively low-importance PR. If anyone feels differently, please comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors thrown have changed in a few places. Update the comments to
reflect the current errors.
The
noAssertoption has been removed but it is still shown in samplecode in a few places. Remove that sample code.
Checklist