Closed
Conversation
Trott
added
test
test/parallel/test-buffer.js
Outdated
Contributor
There was a problem hiding this comment.
Are you sure the Buffer.byteLength call is what you want here? It will coerce the length to a string, then give you the length of that.
Member
Author
|
Pushed a new commit to fix error noted by @brendanashworth |
test/parallel/test-buffer.js
Outdated
Contributor
There was a problem hiding this comment.
These characters are all within the latin-1 charset. check via
Buffer('¡hèlló wôrld!','binary').toString('binary') === '¡hèlló wôrld!'Mind using a two byte utf-8 character?
Member
Author
There was a problem hiding this comment.
OK, changed the è to an έ.
Member
Author
|
Pushed a new commit to include a multibyte character per feedback from @trevnorris |
Contributor
Trott
added a commit
that referenced
this pull request
Jun 17, 2015
PR-URL: #1989 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Contributor
|
Landed in 0abcf44. Thanks much. |
This was referenced Apr 24, 2023
This was referenced Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of another
TODOcomment in the tests.Thing is, I'm not sure this is really needed. There seem to be things in other places in this test file that would trigger
utf8Slice(), at least on casual inspection.So...@chrisdickinson: I know you ran some code coverage analysis recently. Any chance you could run code coverage on just the one file that's changed here and compare it to the results with the version in master to see if this change results in slightly more coverage? Or point me at the code coverage tool you used and I'll try to get up and running with it to do this myself?