Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick b767cde1e7 from upstream V8 #19710

Closed
wants to merge 1 commit into from

Commits on Mar 31, 2018

  1. deps: cherry-pick b767cde1e7 from upstream V8

    Original commit message:
    
        [intl] unbreak build with ICU 57
    
        Remove a call to `icu::toUCharPtr()` that wasn't present in other
        similar looking call sites either, just reinterpret_cast directly.
    
        Fixes nodejs#19656.
    
        Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
        Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3
        Reviewed-on: https://chromium-review.googlesource.com/987953
        Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
        Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
        Cr-Commit-Position: refs/heads/master@{nodejs#52311}
    
    Fixes: nodejs#19656
    bnoordhuis committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    772393c View commit details
    Browse the repository at this point in the history