Skip to content

[v6.x backport] stream: remove unreachable code #19483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v6.x backport] stream: remove unreachable code #19483

wants to merge 2 commits into from

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Mar 20, 2018

This is a backport of #18239.

lpinca added 2 commits March 20, 2018 16:44
@lpinca
stream: remove unreachable code
95abb99 
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.

PR-URL: nodejs#18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@lpinca
test: use correct size in test-stream-buffer-list
e60828e 
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.

PR-URL: nodejs#18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@lpinca
Copy link
Member Author

lpinca commented Mar 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13771/

@lpinca lpinca mentioned this pull request Mar 20, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@lpinca @MylesBorins
stream: remove unreachable code
cb0f658 
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.

Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@lpinca @MylesBorins
test: use correct size in test-stream-buffer-list
708931d 
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.

Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 21, 2018

landed in 8427ec6...708931d

@lpinca lpinca deleted the backport/18239 branch March 21, 2018 06:07
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@lpinca @MylesBorins
stream: remove unreachable code
eeaecce 
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.

Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@lpinca @MylesBorins
test: use correct size in test-stream-buffer-list
e22a645 
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.

Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@lpinca @MylesBorins
stream: remove unreachable code
8f830ca 
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.

Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@lpinca @MylesBorins
test: use correct size in test-stream-buffer-list
5bcf668 
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.

Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lpinca @MylesBorins @nodejs-github-bot