Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.x backport] deps: cherry-pick 15c0c3a8ba and 43e2fb1c3d from upstream V8 #19333

Closed
wants to merge 1 commit into from
Closed

[v9.x backport] deps: cherry-pick 15c0c3a8ba and 43e2fb1c3d from upstream V8 #19333

wants to merge 1 commit into from

Commits on Mar 16, 2018

  1. deps: v8: cherry-pick fixes for v8:7535

    These changes avoid a busy wait loop in V8 CPU Profiler thread for
    windows (except for short intervals).
    
    It would be good if this is also backported to Node.js v9 and LTS
    releases as this busy loop effectively disallows the use of
    cpu-profiler in windows production setups.
    
    Original commit message 15c0c3a8ba:
    ```
    [profiler] use Sleep() on windows for long profile intervals.
    
    See nodejs/diagnostics#170
    
    R=franzih@chromium.org
    
    Change-Id: Iecc3bb27707b0d2afbb23fd9823d5cd4d725be6e
    Reviewed-on: https://chromium-review.googlesource.com/931102
    Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51466}
    ```
    
    Original commit message 43e2fb1c3d:
    ```
    [profiler] fix sleeping on windows for long intervals.
    R=franzih@chromium.org
    
    Change-Id: I5717db794fc797e7c3b0b8f122ddb6dc0702a99e
    Reviewed-on: https://chromium-review.googlesource.com/941126
    Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51755}
    
    ```
    
    Refs: nodejs/diagnostics#170
    Refs: #19200
    Refs: v8/v8@15c0c3a
    Refs: v8/v8@43e2fb1
    Flarna committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    2c6fb1c View commit details
    Browse the repository at this point in the history