Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename regression tests with descriptive file names #19212

Closed
wants to merge 10 commits into from
Prev Previous commit
Next Next commit
test: handle (almost) all nits in #19212
Refs: #19212
Refs: Refs: #19105
  • Loading branch information
ryzokuken committed Mar 8, 2018
commit 8e50585348fd8d2afb3761608d56394e0fdcc670
1 change: 1 addition & 0 deletions test/parallel/test-cluster-kill-disconnect.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const common = require('../common');
// Check that cluster works perfectly for both `kill` and `disconnect` cases.
// Also take into account that the `disconnect` event may be received after the
// `exit` event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe add a link to the GH issue that this test was named for originally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how I could have missed this, will do.

// https://github.com/nodejs/node/issues/3238

const assert = require('assert');
const cluster = require('cluster');
Expand Down
9 changes: 4 additions & 5 deletions test/parallel/test-fs-readfilesync-enoent.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
'use strict';
const common = require('../common');

// This test is only relevant on Windows.
if (!common.isWindows)
common.skip('Windows specific test.');

// This test ensures fs.realpathSync works on properly on Windows without
// throwing ENOENT when the path involves a fileserver
// https://github.com/nodejs/node-v0.x-archive/issues/3542

// This test is only relevant on Windows.

const assert = require('assert');
const fs = require('fs');
const path = require('path');

if (!common.isWindows)
common.skip('Windows specific test.');

function test(p) {
const result = fs.realpathSync(p);
assert.strictEqual(result.toLowerCase(), path.resolve(p).toLowerCase());
Expand Down