Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add node_lib_target_name to cctest deps #18576

Closed
wants to merge 4 commits into from

Commits on Feb 14, 2018

  1. build: add node_lib_target_name to cctest deps

    Currently the cctest target depend on the node_core_target_name
    target. But it is the node_lib_target_name target that compiles the
    sources now which means that if a source file in src is updated the
    cctest executable will not be re-linked against it, but will remain
    unchanged. The code will still be compiled, just not linked which
    means that if you are debugging you'll not see the changes and also a
    warning will be displayed about this issue.
    
    This commit changes the cctest target to depend on node_lib_target_name.
    danbev committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    d39cbf9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9fc08af View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Configuration menu
    Copy the full SHA
    15051d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. squash: add extern "C" to global vars

    It seems that these are not linked properly on Windows with out this.
    danbev committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    d76100c View commit details
    Browse the repository at this point in the history