Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test http exceptions #18506

Closed
wants to merge 8 commits into from
Closed

Refactor test http exceptions #18506

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f802a56
Fixes: https://github.com/nodejs/node/issues/17169 (test-http-excepti…
Bamieh Nov 21, 2017
4cd8fbc
mustCall inside countdown
Bamieh Nov 23, 2017
4286f71
Add test case for countdown
Bamieh Nov 23, 2017
1eb069c
Update countdown docs to hint the change
Bamieh Nov 23, 2017
7ad8ce7
Update README.md
Bamieh Nov 23, 2017
6f125e1
Update README.md
Bamieh Nov 23, 2017
0060979
update readme
Bamieh Feb 1, 2018
6840cf3
up up up one line
Bamieh Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update readme
  • Loading branch information
@Bamieh
Bamieh committed Feb 7, 2018
commit 0060979195902092d99d862e51feaeaf7d8607b5
3 changes: 1 addition & 2 deletions test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,7 @@ Synchronous version of `spawnPwd`.
The `Countdown` module provides a simple countdown mechanism for tests that
require a particular action to be taken after a given number of completed
tasks (for instance, shutting down an HTTP server after a specific number of
requests). Note that _the Countdown will fail the test if the remainder
did not reach 0_.
requests). The Countdown will fail the test if the remainder did not reach 0.

<!-- eslint-disable strict, required-modules -->
```js
Expand Down