test: fix flaky cluster unix socket test #18263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `common.tmpDir` exists before trying to chdir into it. Fixes a "ENOENT: no such file or directory, uv_chdir" error when the temporary directory is removed before running the test.
3 tasks
maclover7
approved these changes
Jan 20, 2018
joyeecheung
approved these changes
Jan 20, 2018
lpinca
approved these changes
Jan 20, 2018
targos
approved these changes
Jan 20, 2018
JungMinu
approved these changes
Jan 20, 2018
|
Running the CI one more time to check that the freebsd failure isn't some weak interaction between cluster tests: https://ci.nodejs.org/job/node-test-commit/15552/ |
cjihrig
approved these changes
Jan 20, 2018
jasnell
approved these changes
Jan 22, 2018
|
Landing... |
maclover7
added
the
author ready
|
Landed in 64ed366e6fc62af434b28c8b3ebd815e6ba51c69 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Ensure `common.tmpDir` exists before trying to chdir into it. Fixes a "ENOENT: no such file or directory, uv_chdir" error when the temporary directory is removed before running the test. PR-URL: #18263 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
common.tmpDirexists before trying to chdir into it. Fixes a"ENOENT: no such file or directory, uv_chdir" error when the temporary
directory is removed before running the test.