Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: dedupe links #18213

Closed
wants to merge 1 commit into from
Closed

doc: dedupe links #18213

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Replace some repeated full links with concise ones and bottom references.

(I've just checked /(\(http[^)]+\))(?=[\s\S]+?\1)/ and /(\([^)]+\.html[^)]*\))(?=[\s\S]+?\1)/ for the doc set, not sure if there are some more proper ways).

Replace some repeated full links
with concise ones and bottom references.
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 17, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 17, 2018
@vsemozhetbyt
Copy link
Contributor Author

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
vsemozhetbyt added a commit that referenced this pull request Jan 18, 2018
Replace some repeated full links
with concise ones and bottom references.

PR-URL: #18213
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in f7c709f

@vsemozhetbyt vsemozhetbyt deleted the doc-dedupe-links branch January 18, 2018 01:17
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
Replace some repeated full links
with concise ones and bottom references.

PR-URL: #18213
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Replace some repeated full links
with concise ones and bottom references.

PR-URL: nodejs#18213
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants