doc: improve PR-review paragraph in CONTRIBUTING.md#17931
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
doc: improve PR-review paragraph in CONTRIBUTING.md#17931Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences.
lpinca
approved these changes
Jan 1, 2018
maclover7
approved these changes
Jan 1, 2018
Contributor
joyeecheung
approved these changes
Jan 1, 2018
jasnell
approved these changes
Jan 1, 2018
cjihrig
approved these changes
Jan 1, 2018
maclover7
added
the
author ready
BridgeAR
approved these changes
Jan 2, 2018
gireeshpunathil
approved these changes
Jan 2, 2018
Contributor
|
Landed in e6a401e |
apapirovski
pushed a commit
that referenced
this pull request
Jan 3, 2018
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: #17931 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: #17931 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: #17931 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: #17931 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
TimothyGu
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2018
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: #17931 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are the same thing in this case.
Break into two clear sentences.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc