Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: spell corrections in http2.md #17911

Closed
wants to merge 2 commits into from
Closed

doc: spell corrections in http2.md #17911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abfafaa
doc: correct spelling in http2.md
sreepurnajasti Dec 29, 2017
12ff1a9
doc: correct spelling in errors.md
sreepurnajasti Dec 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ An operation was performed on a stream that had already been destroyed.
### ERR_HTTP2_MAX_PENDING_SETTINGS_ACK

Whenever an HTTP/2 `SETTINGS` frame is sent to a connected peer, the peer is
required to send an acknowledgement that it has received and applied the new
required to send an acknowledgment that it has received and applied the new
`SETTINGS`. By default, a maximum number of unacknowledged `SETTINGS` frames may
be sent at any given time. This error code is used when that limit has been
reached.
Expand All @@ -964,7 +964,7 @@ forbidden.
<a id="ERR_HTTP2_PING_CANCEL"></a>
### ERR_HTTP2_PING_CANCEL

An HTTP/2 ping was cancelled.
An HTTP/2 ping was canceled.

<a id="ERR_HTTP2_PING_LENGTH"></a>
### ERR_HTTP2_PING_LENGTH
Expand Down Expand Up @@ -1297,11 +1297,11 @@ A failure occurred resolving imports in an [ES6 module][].
<a id="ERR_MULTIPLE_CALLBACK"></a>
### ERR_MULTIPLE_CALLBACK

A callback was called more then once.
A callback was called more than once.

*Note*: A callback is almost always meant to only be called once as the query
can either be fulfilled or rejected but not both at the same time. The latter
would be possible by calling a callback more then once.
would be possible by calling a callback more than once.

<a id="ERR_NAPI_CONS_FUNCTION"></a>
### ERR_NAPI_CONS_FUNCTION
Expand Down
16 changes: 8 additions & 8 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ the handler function will receive three arguments:
added: v8.4.0
-->

The `'localSettings'` event is emitted when an acknowledgement SETTINGS frame
The `'localSettings'` event is emitted when an acknowledgment SETTINGS frame
has been received. When invoked, the handler function will receive a copy of
the local settings.

Expand Down Expand Up @@ -327,7 +327,7 @@ Once destroyed, the `Http2Session` will emit the `'close'` event. If `error`
is not undefined, an `'error'` event will be emitted immediately after the
`'close'` event.

If there are any remaining open `Http2Streams` associatd with the
If there are any remaining open `Http2Streams` associated with the
`Http2Session`, those will also be destroyed.

#### http2session.destroyed
Expand Down Expand Up @@ -371,7 +371,7 @@ added: v8.4.0
* Value: {boolean}

Indicates whether or not the `Http2Session` is currently waiting for an
acknowledgement for a sent SETTINGS frame. Will be `true` after calling the
acknowledgment for a sent SETTINGS frame. Will be `true` after calling the
`http2session.settings()` method. Will be `false` once all sent SETTINGS
frames have been acknowledged.

Expand All @@ -393,12 +393,12 @@ The maximum number of outstanding (unacknowledged) pings is determined by the

If provided, the `payload` must be a `Buffer`, `TypedArray`, or `DataView`
containing 8 bytes of data that will be transmitted with the `PING` and
returned with the ping acknowledgement.
returned with the ping acknowledgment.

The callback will be invoked with three arguments: an error argument that will
be `null` if the `PING` was successfully acknowledged, a `duration` argument
that reports the number of milliseconds elapsed since the ping was sent and the
acknowledgement was received, and a `Buffer` containing the 8-byte `PING`
acknowledgment was received, and a `Buffer` containing the 8-byte `PING`
payload.

```js
Expand Down Expand Up @@ -534,8 +534,8 @@ while the session is waiting for the remote peer to acknowledge the new
settings.

*Note*: The new settings will not become effective until the SETTINGS
acknowledgement is received and the `'localSettings'` event is emitted. It
is possible to send multiple SETTINGS frames while acknowledgement is still
acknowledgment is received and the `'localSettings'` event is emitted. It
is possible to send multiple SETTINGS frames while acknowledgment is still
pending.

#### http2session.type
Expand Down Expand Up @@ -746,7 +746,7 @@ added: v8.4.0
-->

The `'timeout'` event is emitted after no activity is received for this
`'Http2Stream'` within the number of millseconds set using
`'Http2Stream'` within the number of milliseconds set using
`http2stream.setTimeout()`.

#### Event: 'trailers'
Expand Down