http: convert utcDate to use setTimeout #17800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
http
A sort-of follow-up to nodejs#17704, this removes the last internal use of enroll().
Fishrock123
force-pushed
the
utcdate-refactor
branch
from
5e05841 to
1672f00
Compare
cjihrig
approved these changes
Dec 21, 2017
jasnell
approved these changes
Dec 21, 2017
BridgeAR
approved these changes
Dec 21, 2017
evanlucas
approved these changes
Dec 21, 2017
JungMinu
approved these changes
Dec 21, 2017
Contributor
Author
|
Looks like alpine exploded in addon compilation? weird but not really related: https://ci.nodejs.org/job/node-test-commit-linux/15128/nodes=alpine34-container-x64/console |
lpinca
approved these changes
Dec 21, 2017
maclover7
added
the
author ready
addaleax
approved these changes
Dec 27, 2017
addaleax
reviewed
Dec 27, 2017
| } | ||
| utcDate._onTimeout = function() { | ||
|
|
||
| function timeout() { |
Member
There was a problem hiding this comment.
Maybe call this function resetCache or sth like that, timeout doesn't really say what it's doing...
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Dec 28, 2017
A sort-of follow-up to nodejs#17704, this removes the last internal use of enroll(). PR-URL: nodejs#17800 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
A sort-of follow-up to #17704, this removes the last internal use of enroll(). PR-URL: #17800 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
A sort-of follow-up to #17704, this removes the last internal use of enroll(). PR-URL: #17800 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
Contributor
|
Setting don't land as this relies on a semver-major commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sort-of follow-up to #17704, this
removes the last internal use of
enroll().Edit - CI: https://ci.nodejs.org/job/node-test-pull-request/12243/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http