Closed
Conversation
nodejs-github-bot
added
buffer
Member
|
Hello, @WaleedAshraf and thanks for the contribution! I don't think this is an improvement, to be honest. If we specify that something is the default, then it should be expected that the default will be used if the value is undefined. I'd prefer we avoid such "sky is blue unless otherwise noted" explanations and instead remove the text about it being "ignored" entirely. What do you think? |
Contributor
Author
|
Agreed @Trott . |
Contributor
Author
|
Sorry, I forgot to follow guideline for pull request. (Should have rebased instead of merge commit). Let me create a new PR? |
WaleedAshraf
force-pushed
the
issues-17618
branch
from
b5cb2c1 to
5c7b1ec
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes : #17618
Checklist
Affected core subsystem(s)
doc