Skip to content

[8.x backport] test: remove common.fixturesDir #17770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[8.x backport] test: remove common.fixturesDir #17770

wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Dec 20, 2017

Backport of #17400

Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test doc

Trott added 2 commits December 19, 2017 16:33
@Trott
test: remove common.fixturesDir from tests
dcde450 
Use common/fixtures module instead of common.fixturesDir.

PR-URL: nodejs#17400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
test: remove fixturesDir from common module
b1306aa 
Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.

PR-URL: nodejs#17400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Dec 20, 2017
@Trott
Copy link
Member Author

Trott commented Dec 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12216/

@Trott Trott mentioned this pull request Dec 20, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Dec 20, 2017

CI failure looks unrelated:

not ok 504 sequential/test-inspector-stop-profile-after-done
  ---
  duration_ms: 4.193
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:62303/75f4f919-195e-41cf-85d3-dc711e7759c7
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [err] Debugger attached.
    [err] Waiting for the debugger to disconnect...
    [err] 
    { AssertionError [ERR_ASSERTION]: 0 === 3221225477
        at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-stop-profile-after-done.js:26:10)
        at <anonymous>
        at process._tickCallback (internal/process/next_tick.js:188:7)
      generatedMessage: true,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 0,
      expected: 3221225477,
      operator: '===' }
    1
  ...

gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: remove common.fixturesDir from tests
0666968 
Use common/fixtures module instead of common.fixturesDir.

PR-URL: #17400
Backport-PR-URL: #17770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: remove fixturesDir from common module
c6a6a7a 
Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.

PR-URL: #17400
Backport-PR-URL: #17770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@gibfahn
Copy link
Member

gibfahn commented Dec 20, 2017

Landed in 0666968 c6a6a7a

@gibfahn gibfahn closed this Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: remove common.fixturesDir from tests
1be566d 
Use common/fixtures module instead of common.fixturesDir.

PR-URL: #17400
Backport-PR-URL: #17770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: remove fixturesDir from common module
82dfa56 
Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.

PR-URL: #17400
Backport-PR-URL: #17770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: remove common.fixturesDir from tests
0cd4503 
Use common/fixtures module instead of common.fixturesDir.

PR-URL: #17400
Backport-PR-URL: #17770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: remove fixturesDir from common module
3bf3dc4 
Remove common.fixturesDir. All tests now use the the common/fixtures
module instead.

PR-URL: #17400
Backport-PR-URL: #17770
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott Trott deleted the backport-17400-8.x branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gibfahn gibfahn

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott @gibfahn @nodejs-github-bot