Skip to content

[v9.x backport] async_wrap: add provider types for net server #17621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v9.x backport] async_wrap: add provider types for net server #17621

wants to merge 1 commit into from

Conversation

@AndreasMadsen
Copy link
Member

@AndreasMadsen AndreasMadsen commented Dec 11, 2017

Original PR: #17157

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap

@AndreasMadsen
async_wrap: add provider types for net server
ad0934c 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Dec 11, 2017
@AndreasMadsen AndreasMadsen changed the base branch from master to v9.x-staging December 11, 2017 23:27
@AndreasMadsen AndreasMadsen mentioned this pull request Dec 11, 2017
Closed
4 tasks
@AndreasMadsen
Copy link
Member Author

AndreasMadsen commented Dec 11, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12049/

@AndreasMadsen AndreasMadsen removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Dec 11, 2017
@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 12, 2017

landed in b191c9c

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@AndreasMadsen @MylesBorins
async_wrap: add provider types for net server
b191c9c 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

Backport-PR-URL: #17621
PR-URL: #17157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@AndreasMadsen @MylesBorins
async_wrap: add provider types for net server
c2a9e0d 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

Backport-PR-URL: #17621
PR-URL: #17157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@AndreasMadsen @MylesBorins
async_wrap: add provider types for net server
e0ce7cf 
Adds `TCPSERVERWRAP` and `PIPESERVERWRAP` as provider types. This
makes it possible to distinguish servers from connections.

Backport-PR-URL: #17621
PR-URL: #17157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndreasMadsen @MylesBorins @nodejs-github-bot