src: remove unused variable in node_contextify #17491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
cjihrig
reviewed
Dec 6, 2017
I'm really not sure if it is or not. I thought it would be safest to keep it and see what people think. @tniessen Do you by any chance know if this function call is needed? |
fhinkel
approved these changes
Dec 6, 2017
|
@danbev That function should not have side effects, so it should be safe to remove the function call. I am not really sure how |
cjihrig
approved these changes
Dec 6, 2017
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
Refs: nodejs#17394
danbev
force-pushed
the
unused-var-node-contextify
branch
from
1e8a86b to
72e0878
Compare
No problem, I've updated it now. |
addaleax
approved these changes
Dec 7, 2017
|
Landed in 51c6737 |
danbev
added a commit
that referenced
this pull request
Dec 8, 2017
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
This broke v9.x so setting don't land Please feel free to change labels if it should land |
|
@MylesBorins This commit depends on aeddc36 ("src: remove tracking for exception arrow data") PR: #17394, and should not break if that commit is applied first. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2017
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2017
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
|
Most like won't make sense to land in LTS but setting watch in case we backport #17394 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following warning is show when building:
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for exception arrow data").
Refs: #17394
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src