Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use maybe version of SetAccessor #16966

Closed
wants to merge 1 commit into from
Closed

src: use maybe version of SetAccessor #16966

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Nov 12, 2017

Use the SetAccessor function that is not marked as deprecated.

Checklist
Affected core subsystem(s)

src

@fhinkel
src: use maybe version of SetAccessor
adf6459 
Use the SetAccessor function that is not marked as deprecated.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 12, 2017
@addaleax
Copy link
Member

I think this is already covered by #16958, right?

@fhinkel
Copy link
Member Author

fhinkel commented Nov 12, 2017

You're right!

@fhinkel fhinkel closed this Nov 12, 2017
@TimothyGu TimothyGu mentioned this pull request Nov 14, 2017
Closed
2 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@kissofire kissofire mentioned this pull request Mar 7, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Mar 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhinkel @addaleax @nodejs-github-bot