Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: check SecureContext existence #16964

Closed

Commits on Nov 12, 2017

  1. crypto: check SecureContext existence

    Fix:
    
    	*** CID 179169:  Null pointer dereferences  (NULL_RETURNS)
    	/src/node_crypto.cc: 1353 in node::crypto::SecureContext::SetClientCertEngine(const v8::FunctionCallbackInfo<v8::Value> &)()
    	1347
    	1348       // SSL_CTX_set_client_cert_engine does not itself support multiple
    	1349       // calls by cleaning up before overwriting the client_cert_engine
    	1350       // internal context variable.
    	1351       // Instead of trying to fix up this problem we in turn also do not
    	1352       // support multiple calls to SetClientCertEngine.
    	>>>     CID 179169:  Null pointer dereferences  (NULL_RETURNS)
    	>>>     Dereferencing a null pointer "sc".
    	1353       if (sc->client_cert_engine_provided_) {
    	1354         return env->ThrowError(
    	1355             "Multiple calls to SetClientCertEngine are not allowed");
    	1356       }
    	1357
    	1358       const node::Utf8Value engine_id(env->isolate(), args[0]);
    sam-github committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    8fbbb34 View commit details
    Browse the repository at this point in the history