Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix a link in dgram.md #16854

Closed
wants to merge 1 commit into from
Closed

doc: fix a link in dgram.md #16854

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, dgram

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Nov 7, 2017
@vsemozhetbyt vsemozhetbyt changed the title doc: fox a link in dgram.md doc: fix a link in dgram.md Nov 7, 2017
lpinca
lpinca previously approved these changes Nov 7, 2017
@@ -629,7 +629,7 @@ and `udp6` sockets). The bound address and port can be retrieved using
[`socket.address().address`]: #dgram_socket_address
[`socket.address().port`]: #dgram_socket_address
[`socket.bind()`]: #dgram_socket_bind_port_address_callback
[`System Error`]: errors.html#errors_class_system_error
[`System Error`]: errors.html#errors_class_systemerror
Copy link
Member

@lpinca lpinca Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look errors.html#errors_class_system_error seems correct.

@lpinca lpinca dismissed their stale review November 7, 2017 07:19

Link seems correct.

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Nov 7, 2017

@vsemozhetbyt
Copy link
Contributor Author

Landed in 83fcb9f

@vsemozhetbyt vsemozhetbyt deleted the fix-links-20171107 branch November 7, 2017 12:17
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
PR-URL: nodejs#16854
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #16854
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants