Skip to content

added template for better error explanation to assert.ok error message #16829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

added template for better error explanation to assert.ok error message #16829

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
534c3ec
added template for better error explanation to assert.ok error message
chrbergert Nov 6, 2017
41586a2
changed error message to a more speaking information about what happe…
chrbergert Nov 7, 2017
ed558f3
fixing linting issue
chrbergert Nov 7, 2017
7d05644
changed line break to a more standard way
chrbergert Nov 7, 2017
9d58db5
- removed initial change for error message
chrbergert Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/parallel/test-child-process-spawnsync-maxbuf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const args = [
{
const ret = spawnSync(process.execPath, args, { maxBuffer: 1 });

assert.ok(ret.error, 'maxBuffer should error');
assert.ok(ret.error, 'child process does not error \
when maxBuffer is set to 1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this your last commit introduced non-standard indentations. Please will you correct it? The previous commit was fair enough, dont know why you pushed again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review. Sorry, that I have to change it again. I only wanted to fix the error that the linter was throwing, where i exceeded the maximum line length of 80.

assert.strictEqual(ret.error.errno, 'ENOBUFS');
// We can have buffers larger than maxBuffer because underneath we alloc 64k
// that matches our read sizes.
Expand Down