zlib: finish migrating to internal/errors #16540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
errors
nodejs-github-bot
added
c++
|
ping @nodejs/tsc |
XadillaX
approved these changes
Oct 27, 2017
joyeecheung
approved these changes
Oct 27, 2017
| write_js_callback, dictionary, dictionary_len); | ||
| bool ret = Init(ctx, level, windowBits, memLevel, strategy, write_result, | ||
| write_js_callback, dictionary, dictionary_len); | ||
| if (!ret) goto end; |
There was a problem hiding this comment.
Any reason we need a goto here? (other than one less line of duplicate code?)
There was a problem hiding this comment.
just that... didn't want to duplicate the line of code
lpinca
approved these changes
Oct 27, 2017
lpinca
reviewed
Oct 27, 2017
| common.expectsError( | ||
| () => zlib.createDeflateRaw({ windowBits: 8 }), | ||
| { | ||
| code: 'ERR_ZLIB_INITIALIZATION_FAILED', |
There was a problem hiding this comment.
We need a new way to test this error once #16511 is merged.
jasnell
force-pushed
the
migrate-zlib-internal-errors
branch
from
0257a1d
to
c8ef9c3
Compare
jasnell
added a commit
that referenced
this pull request
Oct 29, 2017
PR-URL: #16540 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 896eaf6 |
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16540 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16540 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16540 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish migrating the zlib binding over to use internal/errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
zlib, errors