meta: update comments for module version #16303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 18, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
This LGTM but I'm not sure if node_version.h is the best place for this... can't think of another better location tho.
targos
approved these changes
Oct 18, 2017
Member
|
LGTM. I'd like to fast-track this so I can update the V8 6.2 PR and the V8 upgrade script. |
apapirovski
approved these changes
Oct 18, 2017
Contributor
Author
|
@jasnell I think we should land this and then iterate |
cjihrig
approved these changes
Oct 18, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. Alternatively, all of this information is available at https://nodejs.org/en/download/releases/
MylesBorins
force-pushed
the
update-comment-for-module-versions
branch
2 times, most recently
from
f7e0b01 to
dc30259
Compare
Contributor
Author
|
@cjihrig I've added that information to the comment the one thing not available at that link is module version => V8 ABI version list |
benjamingr
approved these changes
Oct 18, 2017
MylesBorins
added
meta
MylesBorins
force-pushed
the
update-comment-for-module-versions
branch
from
dc30259 to
be6994f
Compare
This commit updates the comment for Module Version to document the history of the Module Version number across the various release of Node.js. PR-URL: nodejs#16303 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins
force-pushed
the
update-comment-for-module-versions
branch
from
be6994f to
aec115b
Compare
Contributor
Author
|
landed in aec115b |
MylesBorins
added a commit
that referenced
this pull request
Oct 23, 2017
This commit updates the comment for Module Version to document the history of the Module Version number across the various release of Node.js. PR-URL: #16303 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
This commit updates the comment for Module Version to document the history of the Module Version number across the various release of Node.js. PR-URL: nodejs/node#16303 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This commit updates the comment for Module Version to document the history of the Module Version number across the various release of Node.js. PR-URL: nodejs/node#16303 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the comment for Module Version to document the
history of the Module Version number across the various release of
Node.js.
/cc @nodejs/v8 @nodejs/release