Skip to content

doc: clarify using crlfDelay with fs streams #16259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: clarify using crlfDelay with fs streams #16259

wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Oct 17, 2017 •
edited
Loading

Checklist
Affected core subsystem(s)

doc, readline

Fixes: #16077

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Oct 17, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Oct 17, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Oct 17, 2017

Linter CI: https://ci.nodejs.org/job/node-test-linter/12690/ (green)

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Oct 18, 2017

Landed in e2cddbb

@vsemozhetbyt vsemozhetbyt deleted the crlfdelay branch October 18, 2017 23:17
vsemozhetbyt added a commit that referenced this pull request Oct 18, 2017
@vsemozhetbyt
doc: clarify using crlfDelay with fs streams
e2cddbb 
PR-URL: #16259
Fixes: #16077
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@vsemozhetbyt @MylesBorins
doc: clarify using crlfDelay with fs streams
497bfff 
PR-URL: #16259
Fixes: #16077
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@vsemozhetbyt @addaleax
doc: clarify using crlfDelay with fs streams
14ddaa2 
PR-URL: nodejs/node#16259
Fixes: nodejs/node#16077
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@vsemozhetbyt @addaleax
doc: clarify using crlfDelay with fs streams
1405eb7 
PR-URL: nodejs/node#16259
Fixes: nodejs/node#16077
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsemozhetbyt @jasnell @Fishrock123 @gireeshpunathil @MylesBorins @nodejs-github-bot