Skip to content

test: http2 priority stream depends on itself #16224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: http2 priority stream depends on itself #16224

wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Oct 15, 2017

This commit add test case where priority() throws ERR_INVALID_OPT_VALUE when stream depends on itself

node/lib/internal/http2/core.js

Lines 893 to 899 in 411695e

if (options.parent === stream[kID]) {
debug(`[${sessionName(this[kType])}] session still connecting. queue ` +
'priority');
throw new errors.TypeError('ERR_INVALID_OPT_VALUE',
'parent',
options.parent);
}

Refs: #14985

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@trivikr
test: http2 priority stream depends on itself
d537492 
This commit add test case where priority() throws ERR_INVALID_OPT_VALUE
when stream depends on itself

Refs: nodejs#14985
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 15, 2017
@lpinca lpinca added the http2 Issues or PRs related to the http2 subsystem. label Oct 15, 2017
@mcollina
Copy link
Member

mcollina commented Oct 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10776/

mcollina
mcollina approved these changes Oct 17, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Oct 17, 2017

failures are unrelated.

@mcollina
Copy link
Member

mcollina commented Oct 17, 2017

Landed as ff747e3

@mcollina mcollina closed this Oct 17, 2017
mcollina pushed a commit that referenced this pull request Oct 17, 2017
@trivikr @mcollina
test: http2 priority stream depends on itself
ff747e3 
This commit add test case where priority() throws ERR_INVALID_OPT_VALUE
when stream depends on itself

Refs: #14985
PR-URL: #16224
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
@trivikr @addaleax
test: http2 priority stream depends on itself
3fef56e 
This commit add test case where priority() throws ERR_INVALID_OPT_VALUE
when stream depends on itself

Refs: nodejs/node#14985
PR-URL: nodejs/node#16224
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@trivikr trivikr deleted the test-http2-priority-parent branch October 22, 2017 21:56
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@trivikr @MylesBorins
test: http2 priority stream depends on itself
e5cf833 
This commit add test case where priority() throws ERR_INVALID_OPT_VALUE
when stream depends on itself

Refs: #14985
PR-URL: #16224
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@apapirovski apapirovski apapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@trivikr @mcollina @apapirovski @jasnell @MylesBorins @lpinca @nodejs-github-bot