Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api,test: use module name macro #16146

Closed
wants to merge 1 commit into from
Closed

n-api,test: use module name macro #16146

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

test_constructor_name.c should use NODE_GYP_MODULE_NAME.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api,test

n-api,test: use module name macro
fcac002 
test_constructor_name.c should use NODE_GYP_MODULE_NAME.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 11, 2017
evanlucas
evanlucas approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/10628/

mhdawson
mhdawson reviewed Oct 11, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this probably applies to other tests as well.

@gabrielschulhof
Copy link
Contributor Author

@mhdawson you're right. There are two more in test/addons-napi/test_warning.

@gabrielschulhof
Copy link
Contributor Author

Landed in 17b818b.

gabrielschulhof pushed a commit that referenced this pull request Oct 13, 2017
n-api,test: use module name macro
17b818b 
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: #16146
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@addaleax
n-api,test: use module name macro
0eeab56 
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: nodejs/node#16146
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@targos
n-api,test: use module name macro
8e7ca5d 
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: #16146
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
n-api,test: use module name macro
45205f0 
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: nodejs#16146
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@MylesBorins
n-api,test: use module name macro
011b53e 
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

Backport-PR-URL: #19447
PR-URL: #16146
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
@gabrielschulhof gabrielschulhof deleted the update-module-name branch April 30, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@digitalinfinity digitalinfinity digitalinfinity approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gabrielschulhof @fhinkel @digitalinfinity @jasnell @evanlucas @mhdawson @nodejs-github-bot