PR - added additional values to error messages. #16009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
addaleax
approved these changes
Oct 7, 2017
Member
tniessen
approved these changes
Oct 7, 2017
| // Issue GH-1140: | ||
| // Test runInContext signature | ||
| let gh1140Exception; | ||
| let gh1140Exp; |
Member
There was a problem hiding this comment.
I don't see the value in changing the variable name (no idea what Exp is supposed to mean).
Member
There was a problem hiding this comment.
+1 ... generally we use more expressive variable names as much as possible.
Contributor
Author
There was a problem hiding this comment.
Proper fix is implemented in pull request #16116
2 tasks
Member
|
Closing in favor of the new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional information to assert error messages to indicate possible problem inside test/parallel/test-vm-context.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
PR
test