src: export the ParseEncoding function on Windows#1596
Closed
ivan wants to merge 1 commit intonodejs:masterfrom
ivan:parse-encoding-extern
Closed
src: export the ParseEncoding function on Windows#1596ivan wants to merge 1 commit intonodejs:masterfrom ivan:parse-encoding-extern
ivan wants to merge 1 commit intonodejs:masterfrom
ivan:parse-encoding-extern
Conversation
Contributor
|
cc @indutny / @bnoordhuis |
src/node.h
Outdated
Member
There was a problem hiding this comment.
Please move v8::Isolate* and friends on a next line at 4 space indent. No need to cascade things ;)
Member
|
Generally, LGTM. Is there anything else that needs exporting? |
Makes the ParseEncoding symbol visible to addons on Windows. It was already visible on Unices.
Contributor
Author
Not that I know about, in |
Member
|
Ok, @Fishrock123 could you please land this? |
Member
|
@ivan btw, thank you for fixing this! ;) |
Contributor
|
@indutny Yep, will do. |
Fishrock123
pushed a commit
that referenced
this pull request
May 7, 2015
Makes the ParseEncoding symbol visible to addons on Windows. It was already visible on Unices. PR-URL: #1596 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
Thanks, landed in c43855c |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
Makes the ParseEncoding symbol visible to addons on Windows. It was already visible on Unices. PR-URL: nodejs#1596 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
ParseEncodingsymbol visible to addons on Windows. It was already visible on Unices.I ran into this when writing an addon that used
ParseEncoding; the VS2013 build failed with:It built fine after adding the
NODE_EXPORT.Similar to an older fix nodejs/node-v0.x-archive#3811