repl: fix persistent history #1593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't comment on the PR itself but the commit log is too light on details. |
|
@bnoordhuis sorry about that. It's a bad habit, but I usually add commit details when merging. |
silverwind
force-pushed
the
fix-repl-history
branch
from
fcf99e4
to
dc9e2b6
Compare
Issue nodejs#1575 did introduce a check for options.terminal but this variable wasn't able to get truthy, which in turn broke persistent history completely. This changes the variable to get truthy on true terminals. Additionally, the docs and the code did differ on which environment variable was used for history. This changes the code to use NODE_REPL_HISTORY_FILE.
silverwind
force-pushed
the
fix-repl-history
branch
from
dc9e2b6
to
df83373
Compare
|
Addded description. |
|
LGTM. |
silverwind
added a commit
that referenced
this pull request
May 2, 2015
Issue #1575 did introduce a check for options.terminal but this variable wasn't able to get truthy, which in turn broke persistent history completely. This changes the variable to get truthy on true terminals. Additionally, the docs and the code did differ on which environment variable was used for history. This changes the code to use NODE_REPL_HISTORY_FILE. PR-URL: #1593 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
Merged in 2e2fce0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ea5195c broke history as
opts.terminalwas never set to a truthy value. Also renamed the history file variable to match the docs.cc: @chrisdickinson @indutny