Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark,path: remove unused variables #15789

Closed
wants to merge 1 commit into from
Closed

benchmark,path: remove unused variables #15789

wants to merge 1 commit into from

Conversation

aladdin-add
Copy link

@aladdin-add aladdin-add commented Oct 5, 2017 •
edited
Loading

some are detected by eslint.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 5, 2017
bnoordhuis
bnoordhuis previously requested changes Oct 5, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you taking the time to put together a PR but none of these changes look even remotely correct.

What exactly did you do and did you run make test?

@mscdex
Copy link
Contributor

mscdex commented Oct 5, 2017

The changes to lib/path.js appear legit, but IMHO it would be better to have them in a separate PR.

@mscdex
Copy link
Contributor

mscdex commented Oct 5, 2017 •
edited
Loading

Also, changes to dependencies should be made in those projects' respective upstream repositories instead of node's repository.

The only remaining change is the change to benchmark/fs/read-stream-throughput.js which seems legit also. In that case, the commit message for this PR should be changed to target the benchmark subsystem (when all of the other changes are removed).

@aladdin-add
Copy link
Author

aladdin-add commented Oct 6, 2017 •
edited
Loading

sorry for the delay. I reset the changes in deps/*. 😃

my local testing failing somehow, but should not be related to the changes -- it was the same when reverting all changes.

image

friendly ping @mscdex @bnoordhuis

@mscdex
Copy link
Contributor

mscdex commented Oct 6, 2017

I think the commit message should be changed if we're going to keep these two changes together. Perhaps something like "benchmark,path: remove unused variables" because our linter currently does not fail without the changes, so the current message is misleading.

@aladdin-add aladdin-add changed the title chore: fix some linting errors. benchmark,path: remove unused variables Oct 6, 2017
@lpinca
Copy link
Member

lpinca commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10522/

@aladdin-add
Copy link
Author

aladdin-add commented Oct 14, 2017 •
edited
Loading

friendly ping @bnoordhuis (。・∀・)ノ

@joyeecheung
Copy link
Member

Ping @bnoordhuis PTAL

@BridgeAR
Copy link
Member

Ping @bnoordhuis your comment seems to be addressed.

@apapirovski
Copy link
Member

Hi @bnoordhuis — it seems your feedback here might've been addressed. Would you mind giving it a look? Thanks!

@BridgeAR BridgeAR dismissed bnoordhuis’s stale review November 22, 2017 19:02

The comment was addressed and seems resolved. PTAL

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2017
@BridgeAR
Copy link
Member

New CI https://ci.nodejs.org/job/node-test-pull-request/11640/

jasnell pushed a commit that referenced this pull request Nov 22, 2017
@jasnell
benchmark,path: remove unused variables
fbb9eef 
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Landed in fbb9eef

@jasnell jasnell closed this Nov 22, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
benchmark,path: remove unused variables
a2229b3 
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
benchmark,path: remove unused variables
ee84fc3 
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@gibfahn
benchmark,path: remove unused variables
5d6fd0d 
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gibfahn
benchmark,path: remove unused variables
9272370 
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2017
@MylesBorins
benchmark,path: remove unused variables
b1b9753 
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
@aladdin-add aladdin-add deleted the chore/linting branch January 3, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis left review comments

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.