Skip to content

http: emit 'aborted' event for ClientRequest #15270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

http: emit 'aborted' event for ClientRequest #15270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a634b83
http: emit 'aborted' event for ClientRequest
ronag Sep 8, 2017
102c621
http: don't emit aborted on request if has response.
ronag Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ function socketCloseListener() {
// NOTE: It's important to get parser here, because it could be freed by
// the `socketOnData`.
var parser = socket.parser;
req.emit('close');

if (req.res && req.res.readable) {
// Socket closed before we emitted 'end' below.
req.res.emit('aborted');
Expand All @@ -375,8 +375,11 @@ function socketCloseListener() {
// fire on the request.
req.socket._hadError = true;
req.emit('error', createHangUpError());
req.emit('aborted');
}

req.emit('close');

// Too bad. That output wasn't getting written.
// This is pretty terrible that it doesn't raise an error.
// Fixed better in v0.10
Expand Down