tools: remove stray package-lock.json file#14873
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
tools: remove stray package-lock.json file#14873Trott wants to merge 2 commits intonodejs:masterfrom
Trott wants to merge 2 commits intonodejs:masterfrom
Conversation
Before the ESLint updates were automated, a stray package-lock.json file was accidentally introduced in the tools directory. This change removes it.
Member
Author
Fishrock123
approved these changes
Aug 16, 2017
aqrln
approved these changes
Aug 16, 2017
Contributor
|
Way is it stray? |
BridgeAR
approved these changes
Aug 17, 2017
jasnell
approved these changes
Aug 17, 2017
cjihrig
approved these changes
Aug 17, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. Should we .gitignore it too?
TimothyGu
approved these changes
Aug 17, 2017
Contributor
|
It was my comment #13895 (comment) that lead to it's inclusion. I still think it's ok to have it here as a sort of a |
Contributor
|
@refack I think the lockfile is redundant as a checksum, given that we already check the dependencies into source control. |
refack
approved these changes
Aug 17, 2017
Contributor
|
Personally I'd rather check in the metadata (i.e. |
Contributor
|
@Trott added a commit with |
Member
Author
|
CI with @refack's addition: https://ci.nodejs.org/job/node-test-pull-request/9742/ |
jasnell
pushed a commit
that referenced
this pull request
Aug 18, 2017
Before the ESLint updates were automated, a stray package-lock.json file was accidentally introduced in the tools directory. This change removes it. PR-URL: #14873 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Member
|
Landed in b5bad25 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Before the ESLint updates were automated, a stray package-lock.json file was accidentally introduced in the tools directory. This change removes it. PR-URL: #14873 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Before the ESLint updates were automated, a stray package-lock.json file was accidentally introduced in the tools directory. This change removes it. PR-URL: #14873 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Contributor
|
Doesn't look like the stray lock made it to v6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the ESLint updates were automated, a stray package-lock.json file
was accidentally introduced in the tools directory. This change removes
it.
Checklist
Affected core subsystem(s)
tools