Skip to content

test: fix test-cluster-send-handle-large-payload #14780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: fix test-cluster-send-handle-large-payload #14780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions test/parallel/test-cluster-send-handle-large-payload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');

const assert = require('assert');
const cluster = require('cluster');
const net = require('net');
Expand All @@ -9,7 +10,7 @@ const payload = 'a'.repeat(800004);
if (cluster.isMaster) {
const server = net.createServer();

server.on('connection', common.mustCall((socket) => socket.unref()));
server.on('connection', common.mustCall((socket) => { socket.unref(); }));

const worker = cluster.fork();
worker.on('message', common.mustCall(({ payload: received }, handle) => {
Expand All @@ -31,10 +32,23 @@ if (cluster.isMaster) {
process.on('message', common.mustCall(({ payload: received }, handle) => {
assert.strictEqual(payload, received);
assert(handle instanceof net.Socket);
process.send({ payload }, handle);

// On macOS, the parent process might not receive a message if it is sent
// to soon, and then subsequent messages are also sometimes not received.
//
// (Is this a bug or expected operating system behavior like the way a file
// watcher is returned before it's actually watching the file system on
// macOS?)
//
// Send a second message after a delay on macOS.
//
// Refs: https://github.com/nodejs/node/issues/14747
if (common.isOSX)
setTimeout(() => { process.send({ payload }, handle); }, 1000);
else
process.send({ payload }, handle);

// Prepare for a clean exit.
process.channel.unref();
handle.unref();
}));
}