test: fix test-readline-interface short delay #14677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Aug 7, 2017
cjihrig
approved these changes
Aug 7, 2017
jasnell
approved these changes
Aug 8, 2017
Trott
approved these changes
Aug 8, 2017
Trott
reviewed
Aug 8, 2017
| @@ -331,8 +331,8 @@ function isWarned(emitter) { | |||
| // over the default crlfDelay but within the setting value | |||
| { | |||
| const fi = new FakeInput(); | |||
| const delay = 200; | |||
| const crlfDelay = 500; | |||
| const delay = common.platformTimeout(125); | |||
There was a problem hiding this comment.
Would this be more reliable without common.platformTimeout() here but keeping it in the line below?
There was a problem hiding this comment.
@Trott Make sense, I have changed this line.
|
Stress test on master (should show failures): https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/27/ Stress test on this PR (should be green): https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/28/ |
|
CI is good, stress tests are great, change is small, will help flip one of our CI tasks from red to green, 4 approvals, so I'm going to fast-track this... |
|
Landed in f11379d |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 8, 2017
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: nodejs#14677 Ref: nodejs#14674 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 10, 2017
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: #14677 Ref: #14674 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
4 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: #14677 Ref: #14674 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes.
This PR use
common.platformTimeoutand widen the time gap, a patch of #13497Refs: #14674
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
readline