Skip to content

[v8.x backport] doc: add documentation for killed property of ChildProcess instance #14632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v8.x backport] doc: add documentation for killed property of ChildProcess instance #14632

wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Aug 4, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Trott added 2 commits August 4, 2017 11:44
@Trott
doc: change child to subprocess
0e9b7fe 
PR-URL: nodejs#14578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott
doc: add entry for subprocess.killed property
9c5a855 
PR-URL: nodejs#14578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Aug 4, 2017
@Trott
Copy link
Member Author

Trott commented Aug 4, 2017

Backport of #14578. (It adds <a name="..."></a> links to preserve old names of links in the 8.x docs. Unneeded in 9.x and forward because those links never existed in those docs.

addaleax pushed a commit that referenced this pull request Aug 7, 2017
@Trott @addaleax
doc: change child to subprocess
342f4cc 
Backport-PR-URL: #14632
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 7, 2017
@Trott @addaleax
doc: add entry for subprocess.killed property
91b7843 
Backport-PR-URL: #14632
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@addaleax
Copy link
Member

addaleax commented Aug 7, 2017

Landed in 342f4cc, 91b7843

@addaleax addaleax closed this Aug 7, 2017
@Trott Trott deleted the v8-backport-14578 branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott @addaleax @refack @nodejs-github-bot