Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] test: increase coverage for path.parse #14521

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] test: increase coverage for path.parse #14521

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Partial backport of #14438 (f7f590c).

@tniessen
test: increase coverage for path.parse
797718d 
PR-URL: nodejs#14438
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@tniessen tniessen added the v8.x label Jul 27, 2017
@tniessen tniessen requested a review from addaleax July 27, 2017 22:58
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Jul 27, 2017
@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9382/

@addaleax addaleax self-assigned this Jul 28, 2017
@addaleax
Copy link
Member

Landed in c704c02, thank you!

@addaleax addaleax closed this Jul 28, 2017
addaleax pushed a commit that referenced this pull request Jul 28, 2017
@tniessen @addaleax
test: increase coverage for path.parse
c704c02 
Backport-PR-URL: #14521
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14438
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

@addaleax addaleax

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tniessen @addaleax @nodejs-github-bot