Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] deps: backport rehash strings after deserialization #14385

Closed
wants to merge 6 commits into from
Closed

[v6.x] deps: backport rehash strings after deserialization #14385

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fb1381
doc: document and test that methods return this
sam-github Jun 7, 2017
dce4a75
test: mark test-fs-readdir-ucs2 flaky
joaocgreis Jun 29, 2017
448c8d4
test: mark test-npm-install flaky on arm
refack Jul 2, 2017
3b2c791
build: run test-hash-seed at the end of test-v8
targos Jul 13, 2017
ddc8050
cluster, dns, repl, tls, util: fix RegExp nits
vsemozhetbyt Jun 7, 2017
adcab4d
deps: backport rehash strings after deserialization
hashseed Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: run test-hash-seed at the end of test-v8 
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@targos @MylesBorins
targos authored and MylesBorins committed Jul 18, 2017
commit 3b2c79190ff00d6935838472de1d191c65a51d1c
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,13 +296,15 @@ test-timers-clean:


ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
test-v8: v8 test-hash-seed
test-v8: v8
# note: performs full test unless QUICKCHECK is specified
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
--no-presubmit \
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
$(TAP_V8)
@echo Testing hash seed
$(MAKE) test-hash-seed

test-v8-intl: v8
# note: performs full test unless QUICKCHECK is specified
Expand Down