Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note for build path #14354

Closed
wants to merge 3 commits into from
Closed

doc: add note for build path #14354

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbc1bd4
doc: add note for Windows build path
Jul 18, 2017
a5911cb
Update BUILDING.md
Jul 18, 2017
db37320
[Squash] Address the nits
jasnell Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ Prerequisites:
* Basic Unix tools required for some tests,
[Git for Windows](http://git-scm.com/download/win) includes Git Bash
and tools which can be included in the global `PATH`.
* NOTE: If the path to your build directory contains a space, the build will likely fail.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Get rid of NOTE: . Just say it: If the path to your build directory contains a space, the build will likely fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure it doesn't get sucked into the GfW bullet point. (maybe add a blank line)


```console
> .\vcbuild
Expand Down