Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSConf CN Code&Learn] test:Replace string concatenation with template literals #14279

Closed
wants to merge 1 commit into from
Closed

[JSConf CN Code&Learn] test:Replace string concatenation with template literals #14279

wants to merge 1 commit into from

Conversation

miccycn
Copy link
Contributor

@miccycn miccycn commented Jul 16, 2017

[JSConf CN Code&Learn]
Replace string concatenation in test/async-hooks/verify-graph.js with template literals.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jul 16, 2017
@miccycn miccycn changed the title test:Replace string concatenation with template test:Replace string concatenation with template literals Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@TimothyGu TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@miccycn miccycn changed the title test:Replace string concatenation with template literals [JSConf CN Code&Learn] test:Replace string concatenation with template literals Jul 16, 2017
@tniessen tniessen self-assigned this Jul 16, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9167/

@Trott
Copy link
Member

Trott commented Jul 16, 2017

CI was green but I canceled some of the slower hosts to help with our CI backlog problem. IMO the CI for this can be treated as green.

@Trott
Copy link
Member

Trott commented Jul 17, 2017 •
edited by refack
Loading

Small change, green CI, 7 approvals, fast-tracking.

Landed in fc71131

refack: fixed typo and the edit makes GitHub link to the commit

@Trott Trott closed this Jul 17, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 17, 2017
@miccycn @Trott
test: replace string concatenation with template
fc71131 
Replace string concatenation with template literals in
test/async-hooks/verify-graph.js.

PR-URL: nodejs#14279
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott
Copy link
Member

Trott commented Jul 17, 2017

Thanks for the contribution! 🎉

@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@miccycn @addaleax
test: replace string concatenation with template
337a865 
Replace string concatenation with template literals in
test/async-hooks/verify-graph.js.

PR-URL: #14279
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@miccycn @Fishrock123
test: replace string concatenation with template
d02f2b9 
Replace string concatenation with template literals in
test/async-hooks/verify-graph.js.

PR-URL: #14279
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@Trott Trott Trott approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees

@tniessen tniessen

Labels
async_hooks Issues and PRs related to the async hooks subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.