n-api: directly create Local from Persistent#14211
Closed
kfarnung wants to merge 1 commit intonodejs:masterfrom
Closed
n-api: directly create Local from Persistent#14211kfarnung wants to merge 1 commit intonodejs:masterfrom
kfarnung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
Contributor
Author
TimothyGu
approved these changes
Jul 13, 2017
cjihrig
approved these changes
Jul 13, 2017
jasongin
approved these changes
Jul 13, 2017
Contributor
Author
|
Rebased and new CI: https://ci.nodejs.org/job/node-test-pull-request/9115/ |
jasnell
approved these changes
Jul 14, 2017
Contributor
Author
|
Rebased again with new CI: https://ci.nodejs.org/job/node-test-pull-request/9233/ |
Contributor
Author
gabrielschulhof
approved these changes
Jul 22, 2017
Contributor
Author
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's just a helper which creates a new `v8::Local` from the given object.
Contributor
Author
|
Rebased and started a new CI: https://ci.nodejs.org/job/node-test-pull-request/9359/ |
addaleax
approved these changes
Jul 26, 2017
Member
|
Landed in e59987c, thanks! |
addaleax
pushed a commit
that referenced
this pull request
Jul 26, 2017
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's just a helper which creates a new `v8::Local` from the given object. PR-URL: #14211 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Contributor
Author
|
Thanks @addaleax! |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's just a helper which creates a new `v8::Local` from the given object. PR-URL: #14211 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's just a helper which creates a new `v8::Local` from the given object. PR-URL: nodejs#14211 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
The `v8::PersistentBase<T>.Get` method didn't exist in node 4 and it's just a helper which creates a new `v8::Local` from the given object. Backport-PR-URL: #19447 PR-URL: #14211 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v8::PersistentBase<T>.Getmethod didn't exist in node 4 and it'sjust a helper which creates a new
v8::Localfrom the given object.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api