Skip to content

doc: add note about python installer #13881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

doc: add note about python installer #13881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ $ [sudo] make install

Prerequisites:

* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* [Python 2.6 or 2.7](https://www.python.org/downloads/)
*Note*: It is recommanded to include the "Add python.exe to path" option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommanded -> recommended ?

Is it a too soft word? Does not build fail without this option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't like installers, so I add it to %Path% manually.
Also there's PEP-0514 (#13882) which I also do manually 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe we should add a note about the alternative ("add it to %Path% manually") if the #13882 has any chance to not cover all the cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note about the alternative ("add it to %Path% manually")

🤔 I don't like "spoon feeding" devs, so I need to think about this.
P.S. The installer will register the installation so #13882 should cover that. (To avoid that I have a special tool that extracts msi files so I can xcopy the extracted files to where I like, and then I do what's necessary for my system to work.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with #13882 landing rather than this note.

I like spoon feeding devs when it comes to tooling (and not code) - I don't want the fact building is hard or unclear to prevent contributors from joining.

* One of:
* [Visual C++ Build Tools](http://landinghub.visualstudio.com/visual-cpp-build-tools)
* [Visual Studio 2015 Update 3](https://www.visualstudio.com/), all editions
Expand Down