Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs,doc,test: open reserved characters under win32 #13875

Closed
wants to merge 5 commits into from
Closed

fs,doc,test: open reserved characters under win32 #13875

wants to merge 5 commits into from

Commits on Jul 5, 2017

  1. fs,doc,test: open reserved characters under win32 

    Explain the behavior of `fs.open()` under win32 that file path contains
some characters and add some test cases for them.

+ < (less than)
+ > (greater than)
+ : (colon)
+ " (double quote)
+ / (forward slash)
+ \ (backslash)
+ | (vertical bar or pipe)
+ ? (question mark)
+ * (asterisk)

Refs: nodejs#13868
Refs: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
Refs: https://msdn.microsoft.com/en-us/library/windows/desktop/bb540537.aspx
    @XadillaX
    XadillaX committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    6a4fdd9 View commit details
    Browse the repository at this point in the history

  2. update after reviewing

    @XadillaX
    XadillaX committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    c335c68 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2017

  1. update after reviewing

    @XadillaX
    XadillaX committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    dff1833 View commit details
    Browse the repository at this point in the history

  2. shrink reserved characters

    @XadillaX
    XadillaX committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    8fc48bb View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2017

  1. fix typo

    @XadillaX
    XadillaX committed Jul 9, 2017
    Configuration menu
    Copy the full SHA
    0237fbc View commit details
    Browse the repository at this point in the history