Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) tools: enforce two arguments in assert.throws #13785

Closed
wants to merge 11 commits into from
Closed

(v6.x backport) tools: enforce two arguments in assert.throws #13785

wants to merge 11 commits into from

Commits on Jun 19, 2017

  1. test: add msg validation to test-buffer-compare 

    PR-URL: nodejs#10807
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @joshholl @targos
    joshholl authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    ffdcfff View commit details
    Browse the repository at this point in the history

  2. test: validate error message from buffer.equals 

    Adding regular expression as an argument to an assert.throws().

PR-URL: nodejs#11215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    @targos
    Sebastian Roeder authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    917e579 View commit details
    Browse the repository at this point in the history

  3. test: improve test-buffer-includes.js 

    * verify error message
* use arrow funcs

PR-URL: nodejs#11203
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @toboid @targos
    toboid authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    4056141 View commit details
    Browse the repository at this point in the history

  4. test: validate errors in test-buffer-indexof 

    * validate errors in assert.throws
* use arrow functions

PR-URL: nodejs#10752
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @edsadr @targos
    edsadr authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    85b17c1 View commit details
    Browse the repository at this point in the history

  5. test: improve the code in test-crypto-dh 

    * validate the errors for all assert.throws
* use arrow functions

PR-URL: nodejs#10734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @edsadr @targos
    edsadr authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    15b4be8 View commit details
    Browse the repository at this point in the history

  6. test: improve test-crypto-rsa-dsa 

    * use const and let instead of var
* use assert.strictEqual or assert.strictDeepEqual instead of assert.equal
* use arrow functions
* swap assertions arguments to match the standard
* validate the error for assert.throws

PR-URL: nodejs#10681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @edsadr @targos
    edsadr authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    f40bd47 View commit details
    Browse the repository at this point in the history

  7. test: extended test to makeCallback cb type check 

    makeCallback and makeStatsCallback are both tested intedependently.

PR-URL: nodejs#12140
Fixes: nodejs#12136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @lucamaraschi @targos
    lucamaraschi authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    0d27e35 View commit details
    Browse the repository at this point in the history

  8. test: improve test-fs-open-flags 

    * use arrow funcion instead of function expression
* add second argument to method assert.throws
* check error messages from beginning to the end using ^ and $

PR-URL: nodejs#10908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @vinimdocarmo @targos
    vinimdocarmo authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    d6b4153 View commit details
    Browse the repository at this point in the history

  9. test: add regex in test_cyclic_link_protection 

    PR-URL: nodejs#11622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @clarenced @targos
    clarenced authored and targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    593553d View commit details
    Browse the repository at this point in the history

  10. test: add second argument to assert.throws 

    This adds RegExp or error constructor arguments to the remaining places
where it is missing in preparation for the commit that will enforce the
presence of at least two arguments.

PR-URL: nodejs#12270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @targos
    targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    7719bc0 View commit details
    Browse the repository at this point in the history

  11. tools: enforce two arguments in assert.throws 

    Enables the requireTwo option of our custom rule.

PR-URL: nodejs#12270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @targos
    targos committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    b411cfb View commit details
    Browse the repository at this point in the history