Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v8.x backport) 12712 - util: add util.callbackify() #13750

Closed
wants to merge 4 commits into from
Closed

(v8.x backport) 12712 - util: add util.callbackify() #13750

wants to merge 4 commits into from

Commits on Jun 17, 2017

  1. util: add callbackify 

    Add `util.callbackify(function)` for creating callback style functions
from functions returning a `Thenable`

PR-URL: nodejs#12712
Fixes: nodejs/CTC#109
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @refack
    refack committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    13c4fd6 View commit details
    Browse the repository at this point in the history

  2. errors: add missing ERR_ prefix on util.callbackify error 

    The `FALSY_VALUE_REJECTION` error code added by
nodejs#12712 did not have the `ERR_` prefix,
nor was it added to the errors.md documentation. Add the prefix in for
consistency.

PR-URL: nodejs#13604
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @jasnell @refack
    jasnell authored and refack committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    3643483 View commit details
    Browse the repository at this point in the history

  3. test: increase util.callbackify() coverage 

    This commit adds coverage for util.callbackify() type checking.

PR-URL: nodejs#13705
    @cjihrig @refack
    cjihrig authored and refack committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    ace4ade View commit details
    Browse the repository at this point in the history

  4. [patch] require('internal/errors')

    @refack
    refack committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    d429bc6 View commit details
    Browse the repository at this point in the history