-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky test-inspector-port-zero-cluster #13711
Conversation
With a properly functioning test, it is possible for a cluster worker to fail to launch due to a port collision. For better or for worse, this is working as expected and so the test now accommodates that reality. Fixes: nodejs#13343
stress test against master (should show some failures): https://ci.nodejs.org/job/node-stress-single-test/1304/ |
stress test against this PR (should show no relevant failures): https://ci.nodejs.org/job/node-stress-single-test/1305/ |
ping @bnoordhuis |
Hey! That's my trick #13373... |
Stress test shows expected failure on master at https://ci.nodejs.org/job/node-stress-single-test/1304/nodes=debian8-64/console. No failures on the stress test CI for this PR. |
@refack Ah, yes, similar for sure. Had I realized they were that similar, I would have suggested that the fix for the flaky test be split out into its own PR so that it doesn't get delayed by reviews for the new tests and any other refactoring that might be going on in that PR. In fact, not too late to do that if you'd prefer. |
(Although I now see that I said I was +1 on creating a known issues test at the same time, so clearly I can't be trusted.) |
CI again since I landed a couple of minor to-be-squashed commits since the last CI: https://ci.nodejs.org/job/node-test-pull-request/8686/ |
I just saw that the blocking review has been dismissed, so I'm going to land #13373 ... |
Killed https://ci.nodejs.org/job/node-stress-single-test/1304/nodes=pi1-raspbian-wheezy/ |
#13373 landed so this is unnecessary. |
With a properly functioning test, it is possible for a cluster worker to
fail to launch due to a port collision. For better or for worse, this is
working as expected and so the test now accommodates that reality.
Fixes: #13343
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test inspector cluster