Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-inspector-port-zero-cluster #13711

Closed
wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 16, 2017

With a properly functioning test, it is possible for a cluster worker to
fail to launch due to a port collision. For better or for worse, this is
working as expected and so the test now accommodates that reality.

Fixes: #13343

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test inspector cluster

With a properly functioning test, it is possible for a cluster worker to
fail to launch due to a port collision. For better or for worse, this is
working as expected and so the test now accommodates that reality.

Fixes: nodejs#13343
@Trott Trott added cluster Issues and PRs related to the cluster subsystem. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Jun 16, 2017
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Jun 16, 2017
@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

stress test against master (should show some failures): https://ci.nodejs.org/job/node-stress-single-test/1304/

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

stress test against this PR (should show no relevant failures): https://ci.nodejs.org/job/node-stress-single-test/1305/

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

ping @bnoordhuis

@refack
Copy link
Contributor

refack commented Jun 16, 2017

Hey! That's my trick #13373...
(anyway IMHO test should be simplified to just parse argv anyway, as that's actually the unit of code it's validating)

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

Stress test shows expected failure on master at https://ci.nodejs.org/job/node-stress-single-test/1304/nodes=debian8-64/console. No failures on the stress test CI for this PR.

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

Hey! That's my trick #13373...

@refack Ah, yes, similar for sure. Had I realized they were that similar, I would have suggested that the fix for the flaky test be split out into its own PR so that it doesn't get delayed by reviews for the new tests and any other refactoring that might be going on in that PR. In fact, not too late to do that if you'd prefer.

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

(Although I now see that I said I was +1 on creating a known issues test at the same time, so clearly I can't be trusted.)

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

CI again since I landed a couple of minor to-be-squashed commits since the last CI: https://ci.nodejs.org/job/node-test-pull-request/8686/

@refack
Copy link
Contributor

refack commented Jun 16, 2017

Hey! That's my trick #13373...

@refack Ah, yes, similar for sure. Had I realized they were that similar, I would have suggested that the fix for the flaky test be split out into its own PR so that it doesn't get delayed by reviews for the new tests and any other refactoring that might be going on in that PR. In fact, not too late to do that if you'd prefer.

I just saw that the blocking review has been dismissed, so I'm going to land #13373 ...

@refack
Copy link
Contributor

refack commented Jun 16, 2017

@Trott
Copy link
Member Author

Trott commented Jun 17, 2017

#13373 landed so this is unnecessary.

@Trott Trott closed this Jun 17, 2017
@Trott Trott deleted the fix-port-zero-clustre branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-inspector-port-zero-cluster
3 participants