Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: use resource objects for Promises #13452

Closed
wants to merge 5 commits into from
Closed

async_hooks: use resource objects for Promises #13452

wants to merge 5 commits into from

Commits on Jun 8, 2017

  1. async_hooks: use resource objects for Promises 

    Use `PromiseWrap` resource objects whose lifetimes are tied to
the `Promise` instances themselves to track promises, and have
a `.promise` getter that points to the `Promise` and a `.parent`
property that points to the parent Promise’s resource object,
if there is any.

The properties are implemented as getters for internal fields
rather than normal properties in the hope that it helps keep
performance for the common case that async_hooks users will
often not inspect them.
    @addaleax
    addaleax committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    a187daa View commit details
    Browse the repository at this point in the history

  2. [squash] provide parent id rather than parent resource

    @addaleax
    addaleax committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    0875682 View commit details
    Browse the repository at this point in the history

  3. [squash] remove getAsyncId

    @addaleax
    addaleax committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    464d2af View commit details
    Browse the repository at this point in the history

  4. [squash] add docs

    @addaleax
    addaleax committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    2652910 View commit details
    Browse the repository at this point in the history

  5. [squash] address nit

    @addaleax
    addaleax committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    4acaed3 View commit details
    Browse the repository at this point in the history