Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: fix deepEqual similar sets and maps bug #13426

Closed
wants to merge 4 commits into from
Closed

assert: fix deepEqual similar sets and maps bug #13426

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3995b72
assert: fix deepEqual similar sets and maps bug
josephg Jun 3, 2017
067be29
assert: Fix nits from review by @refack
josephg Jun 3, 2017
957d610
assert: Added and fixed more failing test cases comparing maps and sets
josephg Jun 3, 2017
4b97dee
assert: Fixed linter errors
josephg Jun 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
assert: Fixed linter errors
  • Loading branch information
@josephg
josephg committed Jun 3, 2017
commit 4b97dee6d5ed61f4929e7a19066886747b432240
4 changes: 2 additions & 2 deletions test/parallel/test-assert-deep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ assertNotDeepOrStrict(new Set([3, '3']), new Set([3, 4]));
assertNotDeepOrStrict(new Map([[3, 0], ['3', 0]]), new Map([[3, 0], [4, 0]]));

assertNotDeepOrStrict(
new Set([{a:1}, {a:1}, {a:2}]),
new Set([{a:1}, {a:2}, {a:2}])
new Set([{a: 1}, {a: 1}, {a: 2}]),
new Set([{a: 1}, {a: 2}, {a: 2}])
);

// This is an awful case, where a map contains multiple equivalent keys:
Expand Down