Skip to content

test: fix build warning in addons-napi\test_object #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: fix build warning in addons-napi\test_object #13412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfdcc47
test: fix build warning in addons-napi\test_object
jasongin Jun 2, 2017
0e62bcb
Address review feedback
jasongin Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/addons-napi/test_object/test_object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
#include <string.h>
#include <stdlib.h>

static int test_value = 3;

napi_value Get(napi_env env, napi_callback_info info) {
size_t argc = 2;
napi_value args[2];
Expand Down Expand Up @@ -145,7 +147,7 @@ napi_value Wrap(napi_env env, napi_callback_info info) {
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &arg, NULL, NULL));

int32_t* data = malloc(sizeof(int32_t));
*data = 3;
*data = test_value;
NAPI_CALL(env, napi_wrap(env, arg, data, NULL, NULL, NULL));
return NULL;
}
Expand All @@ -155,11 +157,12 @@ napi_value Unwrap(napi_env env, napi_callback_info info) {
napi_value arg;
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &arg, NULL, NULL));

int32_t* data;
void* data;
NAPI_CALL(env, napi_unwrap(env, arg, &data));

bool is_expected = (data != NULL && *(int*)data == 3);
napi_value result;
NAPI_CALL(env, napi_get_boolean(env, data != NULL && *data == 3, &result));
NAPI_CALL(env, napi_get_boolean(env, is_expected, &result));
return result;
}

Expand Down