doc: add missing backticks to doc/api/tls.md #13394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
refack
approved these changes
Jun 2, 2017
|
@pbininda Thank you very much for the contribution 🥇 I'd recommend you make yourself familiar with our review & landing procedure Good luck 🤞 |
|
Ohh and welcome 😉 |
|
Yep, the issue is clear in the docs. Thanks for this @pbininda !
Copying the |
gibfahn
approved these changes
Jun 2, 2017
cjihrig
approved these changes
Jun 2, 2017
Fishrock123
approved these changes
Jun 2, 2017
jasnell
approved these changes
Jun 2, 2017
refack
pushed a commit
to refack/node
that referenced
this pull request
Jun 4, 2017
PR-URL: nodejs#13394 Fixes: nodejs#13382 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 7637347 |
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
PR-URL: #13394 Fixes: #13382 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13382
Checklist
Affected core subsystem(s)
doc, tls